Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2534 and #2535 Test in wikipedia and arxiv #2536

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

fnielsen
Copy link
Collaborator

Doctest in arxiv.py failed because of change in error message from the arxiv server. A more general test is now done in the doctest which is not dependent on the specicific error message.

A doctest in wikipedia.py failed because the default requests user agent was banned by the Wikidata Query Service. Now the user agent is set based on the Scholia configuration.

Fixes #2534 and #2535

Description

Please include a summary of the change, relevant motivation and context. If possible and applicable, include before and after screenshots and a URL where the changes can be seen.

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • tox

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

Doctest in arxiv.py failed because of change in error message from the arxiv
server. A more general test is now done in the doctest which is not dependent
on the specicific error message.

A doctest in wikipedia.py failed because the default requests user agent was
banned by the Wikidata Query Service. Now the user agent is set based on the
Scholia configuration.
@fnielsen fnielsen self-assigned this Sep 10, 2024
@fnielsen fnielsen merged commit 84d1ce4 into master Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in doctest for arXiv get_metadata
1 participant